Changeset 4213

Timestamp:

04/21/08 09:25:05 (3 months ago)

Author:

pmoura

Message:

Added support for checking arithmetic expressions for calls to non-portable function calls when using the "portability" compiler flag.

Location:

trunk

Files:

• compiler/logtalk.pl (modified) (7 diffs)
• manuals/index.html (modified) (1 diff)
• manuals/userman/errors.html (modified) (2 diffs)
• manuals/userman/index.html (modified) (1 diff)
• manuals/userman/predicates.html (modified) (2 diffs)
• manuals/userman/programming.html (modified) (3 diffs)
• manuals/userman/running.html (modified) (2 diffs)
• manuals/userman/userman.header (modified) (1 diff)
• RELEASE_NOTES.txt (modified) (1 diff)

trunk/compiler/logtalk.pl

@@ -205 +205 @@
 :- dynamic('$lgt_pp_calls_pred_'/4).            % '$lgt_pp_calls_pred_'(Functor, Arity, TFunctor, TArity)
 :- dynamic('$lgt_non_portable_call_'/2).        % '$lgt_non_portable_call_'(Functor, Arity)
+:- dynamic('$lgt_non_portable_function_'/2).    % '$lgt_non_portable_function_'(Functor, Arity)
 
 :- dynamic('$lgt_pp_defs_nt_'/2).               % '$lgt_pp_defs_nt_'(Functor, Arity)
@@ -4752 +4753 @@
     retractall('$lgt_pp_calls_pred_'(_, _, _, _)),
     retractall('$lgt_non_portable_call_'(_, _)),
+    retractall('$lgt_non_portable_function_'(_, _)),
     retractall('$lgt_pp_defs_nt_'(_, _)),
     retractall('$lgt_pp_calls_nt_'(_, _)),
@@ -7198 +7200 @@
 
 
+% arithmetic predicates (portability checks)
+
+'$lgt_tr_body'(_ is Exp, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp),
+    fail.
+'$lgt_tr_body'(Exp1 =:= Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+'$lgt_tr_body'(Exp1 =\= Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+'$lgt_tr_body'(Exp1 < Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+'$lgt_tr_body'(Exp1 =< Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+'$lgt_tr_body'(Exp1 > Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+'$lgt_tr_body'(Exp1 >= Exp2, _, _, _) :-
+    '$lgt_check_non_portable_functions'(Exp1),
+    '$lgt_check_non_portable_functions'(Exp2),
+    fail.
+
+
 % Logtalk and Prolog built-in (meta-)predicates
 
@@ -7553 +7586 @@
 
 '$lgt_compiler_db_pred_ind_chk'(_).
+
+
+
+% '$lgt_check_non_portable_functions'(@term)
+%
+% checks an arithmetic expression for calls to non-standard Prolog functions
+
+
+'$lgt_check_non_portable_functions'(Exp) :-
+    var(Exp),
+    !.
+
+'$lgt_check_non_portable_functions'(Exp) :-
+    number(Exp),
+    !.
+
+'$lgt_check_non_portable_functions'(Exp) :-
+    '$lgt_iso_spec_function'(Exp),
+    !,
+    Exp =.. [_| Exps],
+    '$lgt_check_non_portable_function_args'(Exps).
+
+'$lgt_check_non_portable_functions'(Exp) :-
+    functor(Exp, Functor, Arity),
+    (   '$lgt_non_portable_function_'(Functor, Arity) ->
+        true
+    ;   assertz('$lgt_non_portable_function_'(Functor, Arity))
+    ),
+    Exp =.. [_| Exps],
+    '$lgt_check_non_portable_function_args'(Exps).
+
+
+'$lgt_check_non_portable_function_args'([]).
+
+'$lgt_check_non_portable_function_args'([Exp| Exps]) :-
+    '$lgt_check_non_portable_functions'(Exp),
+    '$lgt_check_non_portable_function_args'(Exps).
 
 
@@ -8609 +8679 @@
         '$lgt_report_misspelt_calls',
         '$lgt_report_non_portable_calls',
+        '$lgt_report_non_portable_functions',
         '$lgt_report_unknown_entities'
     ;   true
@@ -10153 +10224 @@
     functor(Pred, Functor, Arity),
     \+ '$lgt_pp_redefined_built_in_'(Pred, _, _, _, _).
+
+
+
+% report non-portable arithmetic function calls in the body of object and category predicates
+
+'$lgt_report_non_portable_functions' :-
+    '$lgt_compiler_flag'(portability, warning),
+    setof(Functor/Arity, '$lgt_non_portable_function_'(Functor, Arity), Functions),
+    '$lgt_inc_compile_warnings_counter',
+    nl,
+    (   Functions = [_] ->
+        write('  WARNING!  Call to non-standard Prolog built-in arithmetic function: ')
+    ;   write('  WARNING!  Calls to non-standard Prolog built-in arithmetic functions: ')
+    ),
+    '$lgt_writeq_list'(Functions),
+    !.
+
+'$lgt_report_non_portable_functions'.
 
 
@@ -12706 +12795 @@
 '$lgt_iso_spec_pred'(halt).
 '$lgt_iso_spec_pred'(halt(_)).
+
+
+
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%
+%  table of ISO specified arithmetic functions
+%
+%  (used for portability checking)
+%
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
+
+
+'$lgt_iso_spec_function'('-'(_)).
+'$lgt_iso_spec_function'('+'(_, _)).
+'$lgt_iso_spec_function'('-'(_, _)).
+'$lgt_iso_spec_function'('*'(_, _)).
+'$lgt_iso_spec_function'('/'(_, _)).
+'$lgt_iso_spec_function'('//'(_, _)).
+'$lgt_iso_spec_function'(rem(_, _)).
+'$lgt_iso_spec_function'(mod(_, _)).
+'$lgt_iso_spec_function'('/\\'(_, _)).
+'$lgt_iso_spec_function'('\\/'(_, _)).
+'$lgt_iso_spec_function'('\\'(_, _)).
+'$lgt_iso_spec_function'('<<'(_, _)).
+'$lgt_iso_spec_function'('>>'(_, _)).
+'$lgt_iso_spec_function'('**'(_, _)).
+
+'$lgt_iso_spec_function'(abs(_)).
+'$lgt_iso_spec_function'(sign(_)).
+'$lgt_iso_spec_function'(sqrt(_)).
+'$lgt_iso_spec_function'(atan(_)).
+'$lgt_iso_spec_function'(cos(_)).
+'$lgt_iso_spec_function'(sin(_)).
+'$lgt_iso_spec_function'(exp(_)).
+'$lgt_iso_spec_function'(log(_)).
+'$lgt_iso_spec_function'(float(_)).
+'$lgt_iso_spec_function'(ceiling(_)).
+'$lgt_iso_spec_function'(floor(_)).
+'$lgt_iso_spec_function'(round(_)).
+'$lgt_iso_spec_function'(truncate(_)).
+'$lgt_iso_spec_function'(float_fractional_part(_)).
+'$lgt_iso_spec_function'(float_integer_part(_)).
 
 

trunk/manuals/index.html

@@ -32 +32 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/> 
-        <span>Last updated on: April 19, 2008</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/errors.html

@@ -90 +90 @@
 
 <p>
-A warning will be reported if a predicate clause contains a call to a non-ISO defined built-in predicate.
+A warning will be reported if a predicate clause contains a call to a non-ISO specified built-in predicate or to a non-ISO specified arithmetic function.
 </p>
 
@@ -126 +126 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/> 
-        <span>Last updated on: April 14, 2007</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/index.html

@@ -302 +302 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/>
-        <span>Last updated on: April 9, 2008</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/predicates.html

@@ -660 +660 @@
 </p>
 <p>
-When calling non-standard Prolog built-in predicates, you may run into portability problems while trying your applications with different back-end Prolog compilers (non-standard predicates are often specific to a Prolog compiler). You may use the Logtalk compiler flag <a title="Consult user manual" href="running.html#options"><code>portability/1</code></a> to help check for problematic calls in your code.
+When calling non-standard Prolog built-in predicates or using non-standard Prolog arithmetic functions, you may run into portability problems while trying your applications with different back-end Prolog compilers (non-standard predicates and non-standard arithmetic functions are often specific to a Prolog compiler). You may use the Logtalk compiler flag <a title="Consult user manual" href="running.html#options"><code>portability/1</code></a> to help check for problematic calls in your code.
 </p>
 
@@ -676 +676 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/> 
-        <span>Last updated on: April 7, 2008</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/programming.html

@@ -99 +99 @@
 
 <p>
-Logtalk is compatible with almost all modern Prolog compilers. However, this does not necessarily imply that your Logtalk programs will have the same level of portability. If possible, you should only use in your programs Logtalk built-in predicates and ISO Prolog defined built-in predicates. If you need to use built-in predicates that may not be available in other Prolog compilers, you should try to encapsulate the non-portable code in a small number of objects and provide a portable <strong>interface</strong> for that code through the use of Logtalk protocols. An example will be code that access operating-system specific features. The Logtalk compiler can warn you of the use of non-ISO defined built-in predicates by using the <code>portability/1</code> compiler flag.
+Logtalk is compatible with almost all modern Prolog compilers. However, this does not necessarily imply that your Logtalk programs will have the same level of portability. If possible, you should only use in your programs Logtalk built-in predicates and ISO Prolog specified built-in predicates and arithmetic functions. If you need to use built-in predicates (or built-in arithmetic functions) that may not be available in other Prolog compilers, you should try to encapsulate the non-portable code in a small number of objects and provide a portable <strong>interface</strong> for that code through the use of Logtalk protocols. An example will be code that access operating-system specific features. The Logtalk compiler can warn you of the use of non-ISO specified built-in predicates and arithmetic functions by using the <code>portability/1</code> compiler flag.
 </p>
 
@@ -123 +123 @@
 </p>
 
-<h3 id="programming_style">Coding style guidlines</h3>
+<h3 id="programming_style">Coding style guidelines</h3>
 
 <p>
@@ -163 +163 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/> 
-        <span>Last updated on: January 21, 2008</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/running.html

@@ -119 +119 @@
     <dl>
         <dt><code>portability(Option)</code></dt>
-            <dd>Controls the non-ISO specified built-in predicate calls warnings. Possible option values are <code>warning</code> and <code>silent</code> (the usual default).</dd>
+            <dd>Controls the non-ISO specified built-in predicate and non-ISO specified built-in arithmetic function calls warnings. Possible option values are <code>warning</code> and <code>silent</code> (the usual default).</dd>
     </dl>
     <dl>
@@ -515 +515 @@
     <div class="copyright">
         <span>Copyright &copy; <a href="mailto:pmoura@logtalk.org">Paulo Moura</a> &mdash; <a href="http://logtalk.org">Logtalk.org</a></span><br/> 
-        <span>Last updated on: April 9, 2008</span>
+        <span>Last updated on: April 21, 2008</span>
     </div>
     <div class="navbottom">

trunk/manuals/userman/userman.header

@@ -36 +36 @@
         <span>http://logtalk.org/</span>
     </p>
-    <p class="date">Last updated on April 19, 2008</p>
+    <p class="date">Last updated on April 21, 2008</p>
 </div>
 

trunk/RELEASE_NOTES.txt

@@ -12 +12 @@
 
 2.31.5 - April ??, 2008
+
+    Added support for checking arithmetic expressions for calls to 
+    non-portable function calls when using the "portability" compiler 
+    flag.
 
     Updated the implementation of the threaded/1 built-in predicate to